1. Forum
  2. DOVE-Net
  3. Synchronet Programming

  • src/sbbs3/file.cpp

    From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Mon Aug 11 15:51:59 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/f226ae0d2a9425f6722c76fd
    Modified Files:
    src/sbbs3/file.cpp
    Log Message:
    We should fully initialized the user struct before calling adjustuserval()

    ... since adjustuserval() may call resetdailyuserdat() which uses user.level
    to index into scfg.level_freecdtperday[]... but only for daily reset fields which in this instance, we're not actually adjusting user fields of that type. So it's really a false positive issue from Coverity, but let's go ahead and
    fix for best-practices sake.

    Fixes CID 583999

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Tue Sep 29 17:07:32 2026
    https://gitlab.synchro.net/main/sbbs/-/commit/08058a23f007f358492747b0
    Modified Files:
    src/sbbs3/file.cpp
    Log Message:
    File name editor: check the new name, not an uninitialized buffer

    When a sysop renamed a file from the file-info editor, the check for an existing file of the new name was handed 'path' before anything had been written to it, rather than the name just entered. The check read stack
    garbage, so renaming a file onto another in the same directory was not
    refused: it overwrote that file on disk and left two index records with
    the same name.

    Present since ef11784f06 (founder-3-nickel, 2021-05-13), which added file
    info editing from the extended file info prompt.

    Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net